Use real run numbers for geometry #346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baltzell
force-pushed
the
iss59-detChangedHook-redux
branch
from
51184f4 to
c4db3b1
Compare
Collaborator
Author
|
Test failing on EC photon efficiency for run 11. Cole says it's due to remaining CCDB changes needed (triggered by the removal of "isMC" run number check), which was anticipated. Retrigger CI after fixing CCDB. |
baltzell
force-pushed
the
iss59-detChangedHook-redux
branch
from
f0a05e8 to
fdb9e47
Compare
Collaborator
Author
|
test files regenerated with latest gemc/dev, still no reconstructed photons ... |
Collaborator
Author
|
From the CI logs for the electrongamma test: So, 88% of photons are getting misidentified as neutrons. (The test threshold is so far 84% photon efficiency). |
Collaborator
Author
|
And the electronneutron test: This is more of a distraction, due to different requirements in the efficiency calculations for the matrix and the actual test failure, and upon closer look probably has the same cause as the photon failure (timing). |
baltzell
force-pushed
the
iss59-detChangedHook-redux
branch
from
1ca3a76 to
b6c5fee
Compare
Collaborator
Author
|
github appears broken, closing to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added abstract method detectorChanged(int run) to ReconstructionEngine, which is called automatically when the run number changes.
Moved every engine's geometry initialization from init or elsewhere to detectorChanged.
Changed the name of ReconstructionEngine's abstract event-processing method from processDataEvent to procesDataEventUser, and filterEvent to processDataEvent, such that all external uses of processDataEvent still do the right thing.
And removed EC's run number check per Cole.
Closes #59